-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added alias for chatview #820
Conversation
File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatViewComponent.tsx
File: packages/examples/sdk-frontend-react/src/app/app.tsx
File: packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfile.tsx
File: packages/uiweb/src/lib/components/chat/ChatViewComponent/index.ts
File: packages/uiweb/src/lib/components/chat/ConnectButton/ConnectButton.tsx
File: packages/uiweb/src/lib/components/chat/MessageInput/MessageInput.tsx
File: packages/uiweb/src/lib/dataProviders/ChatDataProvider.tsx
File: packages/uiweb/src/lib/hooks/useCreateChatProfile.ts
All looks good. |
In ChatUITest/ChatViewComponent.tsx file:
In app.tsx file:
In ChatProfile.tsx file:
In ChatProfile.tsx file:
In ChatProfile.tsx file:
In ChatProfile.tsx file:
In index.ts file:
These are the issues I found in the specified files. Please address them and let me know if you have any questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of it working fine for me.
changed name of ChatViewComponent to ChatView
shifted handleUsercreation method from connectButton to chatDataProvider so that just passing signer will create account and pgpPrivatekey.
added relative global modal positioning
added chain details to criteria