Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added alias for chatview #820

Merged
merged 3 commits into from
Nov 9, 2023
Merged

fix: added alias for chatview #820

merged 3 commits into from
Nov 9, 2023

Conversation

mishramonalisha76
Copy link
Contributor

@mishramonalisha76 mishramonalisha76 commented Nov 7, 2023

changed name of ChatViewComponent to ChatView
shifted handleUsercreation method from connectButton to chatDataProvider so that just passing signer will create account and pgpPrivatekey.
added relative global modal positioning
added chain details to criteria

Copy link

github-actions bot commented Nov 7, 2023

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatViewComponent.tsx

  • The import for Section from '../components/StyledComponents' seems to be missing. Please make sure it is imported correctly.
  • The import for MODAL_BACKGROUND_TYPE from "@pushprotocol/uiweb" seems to be missing. Please make sure it is imported correctly.
  • The import for ChatView from '@pushprotocol/uiweb' seems to be missing. Please make sure it is imported correctly.
  • There are two commented lines of code for the CreateGroupModal component. Please remove the commented lines if they are not needed.
  • The ChatViewComponentCard component is not defined. Please define the component or remove the usage.

File: packages/examples/sdk-frontend-react/src/app/app.tsx

  • The import for ConnectButtonComp seems to be missing. Please make sure it is imported correctly.
  • The import for routes seems to be missing. Please make sure it is imported correctly.
  • The closing </Link> tag for "SECRET NOTIFICATION" seems to be missing. Please add the closing tag.

File: packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfile.tsx

  • There is a missing closing } for the getProfileName function. Please add the closing } at the end of the function.
  • There is a missing closing } for the getImage function. Please add the closing } at the end of the function.
  • There is a missing closing } for the ChatProfile component. Please add the closing } at the end of the component.

File: packages/uiweb/src/lib/components/chat/ChatViewComponent/index.ts

  • The export for ChatViewComponent seems to be duplicated. Please remove one of the duplicate exports.

File: packages/uiweb/src/lib/components/chat/ConnectButton/ConnectButton.tsx

  • The file is empty. Please add the necessary code for the ConnectButton component.

File: packages/uiweb/src/lib/components/chat/MessageInput/MessageInput.tsx

  • There is a missing closing } for the sendGIF function. Please add the closing } at the end of the function.
  • There is a missing closing } for the sendTextMsg function. Please add the closing } at the end of the function.
  • There is a missing closing } for the updateChatFeed function. Please add the closing } at the end of the function.
  • There is a missing closing } for the MessageInput component. Please add the closing } at the end of the component.

File: packages/uiweb/src/lib/dataProviders/ChatDataProvider.tsx

  • The file is empty. Please add the necessary code for the ChatDataProvider component.

File: packages/uiweb/src/lib/hooks/useCreateChatProfile.ts

  • The file is empty. Please add the necessary code for the useCreateChatProfile hook.

All looks good.

Copy link

github-actions bot commented Nov 9, 2023

In ChatUITest/ChatViewComponent.tsx file:

  • On line 4, the import statement for Section is not located in the correct file path.
  • On lines 6 and 7, the import statements for CreateGroupModal, MODAL_BACKGROUND_TYPE, and MODAL_POSITION_TYPE are imported from "@pushprotocol/uiweb", but it seems like they should be imported from a different package or file.
  • On line 9, the import statement for ChatView is imported from "@pushprotocol/uiweb", but it seems like it should be imported from a different package or file.

In app.tsx file:

  • On lines 56, 64, 70, 76, 82, 88, 94, 100, 106, 112, 118, 124, 130, 136, 142, and 148, the closing Link tags are missing.

In ChatProfile.tsx file:

  • On line 81, the closing Link tag is missing.
  • On line 91, the closing Link tag is missing.
  • On line 98, the closing Link tag is missing.
  • On line 105, the closing Link tag is missing.
  • On line 112, the closing Link tag is missing.
  • On line 119, the closing Link tag is missing.
  • On line 126, the closing Link tag is missing.
  • On line 133, the closing Link tag is missing.
  • On line 141, the closing Link tag is missing.
  • On line 150, the closing Link tag is missing.
  • On line 159, the closing Link tag is missing.
  • On line 168, the closing Link tag is missing.
  • On line 177, the closing Link tag is missing.
  • On line 186, the closing Link tag is missing.
  • On line 195, the closing Link tag is missing.
  • On line 204, the closing Link tag is missing.
  • On line 213, the closing Link tag is missing.

In ChatProfile.tsx file:

  • On line 205, the closing ImageItem tag is missing.

In ChatProfile.tsx file:

  • On line 253, the closing ImageItem tag is missing.

In ChatProfile.tsx file:

  • On line 271, the closing Container tag is missing.
  • On line 334, the closing Section tag is missing.

In index.ts file:

  • On line 2, two exports with the name ChatViewComponent are conflicting.

These are the issues I found in the specified files. Please address them and let me know if you have any questions.

Copy link
Contributor

@pritipsingh pritipsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of it working fine for me.

@mishramonalisha76 mishramonalisha76 merged commit 2940242 into alpha Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants